Apply suggestions from code review

Co-Authored-By: Georg Brandl <[email protected]>
PyO3 · Mar 22, 2020 · ec2b66f · ec2b66f
1 parent 9b5ea3f
commit ec2b66f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/pyo3-derive-backend/src/pyclass.rs b/pyo3-derive-backend/src/pyclass.rs
@@ -93,7 +93,7 @@ impl PyClassArgs {
                 syn::Expr::Path(exp) if exp.path.segments.len() == 1 => {
                     self.name = Some(exp.clone().into());
                 }
-                _ => expected!("single type path(e.g., Name)"),
+                _ => expected!("type name (e.g., Name)"),
             },
             "extends" => match &**right {
                 syn::Expr::Path(exp) => {
@@ -103,7 +103,7 @@ impl PyClassArgs {
                     };
                     self.has_extends = true;
                 }
-                _ => expected!("type path(e.g., my_mod::MyClass)"),
+                _ => expected!("type path (e.g., my_mod::MyClass)"),
             },
             "module" => match &**right {
                 syn::Expr::Lit(syn::ExprLit {
@@ -112,7 +112,7 @@ impl PyClassArgs {
                 }) => {
                     self.module = Some(lit.clone());
                 }
-                _ => expected!(r#"string literal(e.g., "mymod")"#),
+                _ => expected!(r#"string literal (e.g., "mymod")"#),
             },
             x => {
                 return Err(syn::Error::new_spanned(

diff --git a/tests/ui/invalid_pyclass_args.stderr b/tests/ui/invalid_pyclass_args.stderr
@@ -4,19 +4,19 @@ error: Expected one of freelist/name/extends/module, but got extend
 3 | #[pyclass(extend=pyo3::types::PyDict)]
   |           ^^^^^^
 
-error: Expected type path(e.g., my_mod::MyClass), but got "PyDict"
+error: Expected type path (e.g., my_mod::MyClass), but got "PyDict"
  --> $DIR/invalid_pyclass_args.rs:6:21
   |
 6 | #[pyclass(extends = "PyDict")]
   |                     ^^^^^^^^
 
-error: Expected single type path(e.g., Name), but got m :: MyClass
+error: Expected type name (e.g., Name), but got m :: MyClass
  --> $DIR/invalid_pyclass_args.rs:9:18
   |
 9 | #[pyclass(name = m::MyClass)]
   |                  ^^^^^^^^^^
 
-error: Expected string literal(e.g., "mymod"), but got my_module
+error: Expected string literal (e.g., "mymod"), but got my_module
   --> $DIR/invalid_pyclass_args.rs:12:20
    |
 12 | #[pyclass(module = my_module)]