Merge master into abi3 branch, resolving conflicts #1245
Conversation
This lets us treat it no different from other types like PySequence.
Those functions and variable are listed in https://docs.python.org/3.10/whatsnew/3.10.html#id4
Co-authored-by: David Hewitt <[email protected]>
Release 0.12.3
Remove unused `python3` feature
Remove special case of PyIterator
Remove symbols that are removed in python 3.10
Displays type(obj) instead of repr(obj) and uses `cannot` instead of `can't` to be more consistent with existing python error messages. See discussion at PyO3#1212.
guide: fix broken link
…ame-to-conversion-error Enhance error messages of conversion errors
examples: add Pyre
|
Seems we've run into a pickle. |
alex
force-pushed
the
abi3-merge-master
branch
from
c22b879 to
e8dc226
Compare
I checked CPython source but just found no alternative. Maybe opting-in the feature is the only solution. |
alex
force-pushed
the
abi3-merge-master
branch
from
e8dc226 to
265db33
Compare
|
Ok, that's what I did -- PyTryFrom for PyIterator is now only on |
|
BTW, I'm now preparing the proc-macro refactoring for abi3 branch, which (I hope) would make this branch ready to merge. |
|
Ok. I hope we can get this merged soon, the merge conflicts are no fun. |
|
I have no idea why the one Windows py35 build is failing. I think @davidhewitt mentioned that ya'll plan to drop py35 anyways. |
Without having a Py (which ensures the GIL is held) multiple thraeds could call get_free_list concurrently.
Make get_free_list API sound
Fix lifetime soundness in freelist
👍 Good thing I added extra test coverage as good hygiene during #1176!
See #1250 - do you want me to merge this PR now or wait until that merges? |
|
I think it's epsilon easier to merge 1250 first, since I'll just have to
merge master in again to get this green. But if it's easier for you to
merge this first for whatever reason, that also works.
…On Sun, Oct 18, 2020 at 5:57 PM David Hewitt ***@***.***> wrote:
Ok, that's what I did -- PyTryFrom for PyIterator is now only on
any(not(Py_LIMITED_API), Py_3_8)
👍 Good thing I added extra test coverage as good hygiene during #1176
<#1176>!
I think @davidhewitt <https://github.com/davidhewitt> mentioned that
ya'll plan to drop py35 anyways.
See #1250 <#1250> - do you want me to
merge this PR now or wait until that merges?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1245 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAGBF5BWG2PTS27HFAV73SLNQE7ANCNFSM4SVEEXWA>
.
--
All that is necessary for evil to succeed is for good people to do nothing.
|
Drop support for Python 3.5
|
Because something must always be broken, GHA appears to have not started one of the jobs. But all the other jobs passed. |
|
CI is all green to me! Thanks, merging. |
No description provided.