Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change PyErr::fetch to return an Option<PyErr> #1717

Merged
merged 3 commits into from
Aug 11, 2021
Merged

Change PyErr::fetch to return an Option<PyErr> #1717

merged 3 commits into from
Aug 11, 2021

Conversation

messense
Copy link
Member

@messense messense commented Jul 5, 2021

Closes #1715

birkenfeld
birkenfeld reviewed Jul 5, 2021
View reviewed changes
src/err/mod.rs Outdated Show resolved Hide resolved
src/types/dict.rs Outdated Show resolved Hide resolved
src/types/typeobject.rs Outdated Show resolved Hide resolved
src/types/typeobject.rs Outdated Show resolved Hide resolved
@messense messense force-pushed the pyerr-fetch branch 2 times, most recently from f624ceb to cb90c64 Compare July 5, 2021 13:53
@messense messense marked this pull request as ready for review July 6, 2021 00:01
@davidhewitt davidhewitt added this to the 0.15 milestone Jul 6, 2021
@messense messense force-pushed the pyerr-fetch branch 2 times, most recently from 03331d5 to 8eedf29 Compare July 6, 2021 14:17
davidhewitt
davidhewitt approved these changes Jul 8, 2021
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but let's wait to merge it until we're closer to the 0.15 release because I think we might have a patch release or two in the 0.14 line yet.

I'll happily rebase and add a CHANGELOG at that point.

Thanks!

@davidhewitt davidhewitt mentioned this pull request Jul 24, 2021
Closed
@davidhewitt
Copy link
Member

I think it's ok to start merging stuff for 0.15, so I'm going to rebase and merge this now.

@davidhewitt davidhewitt merged commit bdad08c into PyO3:main Aug 11, 2021
@messense messense deleted the pyerr-fetch branch August 12, 2021 02:34
@davidhewitt davidhewitt mentioned this pull request Oct 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@birkenfeld birkenfeld birkenfeld left review comments

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.15
Development

Successfully merging this pull request may close these issues.
3 participants
@messense @davidhewitt @birkenfeld