Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: 0.15.0 #1949

Merged
merged 1 commit into from
Nov 3, 2021
Merged

release: 0.15.0 #1949

merged 1 commit into from
Nov 3, 2021

Conversation

davidhewitt
Copy link
Member

Closes #1921

As per that #1921, I think there's plenty of changes now accumulated which would be worth releasing as 0.15.

There might be a couple of extra fixes which merge (such as updates for PyPy), and maybe experimental versions of sequence / gc / buffer protocols if I get a chance to implement them.

I'll put live on Saturday if I hear no reason to delay.

@indygreg - for PyOxidizer would it be helpful if I produced a 0.15.0-rc.1 release for you to use before then?

@indygreg
Copy link
Contributor

For testing PyOxidizer, I can point Cargo at a Git branch/commit for testing. As long as I can get CI passing against what will become 0.15.0, I should be good. Thanks for thinking about me!

I've already started testing the release-0.15 branch and found a regression, which #1950 should fix.

@indygreg
Copy link
Contributor

Looks like PyOxidizer's port to PyO3 0.15 is trivial: https://github.com/indygreg/PyOxidizer/tree/pyo3-015. Aside from the missing memory API symbols, this release/branch seems to look great from PyOxidizer's perspective! The port was pretty trivial and all issues were identified from compiler errors. And all compiler errors were from changes captured in the changelog.

@alex
Copy link
Contributor

alex commented Oct 24, 2021

pyca/cryptography is green with 0.15 (pyca/cryptography#6472)

@davidhewitt
Copy link
Member Author

From the PRs I have seen updating to this release candidate, I would like to make a decision on #1957 which reverts the breaking change around PyErr::fetch before making the final release.

@mejrs
Copy link
Member

mejrs commented Oct 30, 2021

From the PRs I have seen updating to this release candidate, I would like to make a decision on #1957 which reverts the breaking change around PyErr::fetch before making the final release.

How many people use it directly and how do they use it?

Just scrolling through greg's PR, something like PyErr::fetch() -> Result<(), PyErr> also makes some sense.

For example, that allows writing things like:

if !unsafe { pyffi::PyErr_Occurred() }.is_null() {
    return Err(PyErr::fetch(py).expect("error should have occurred"));
}

as

PyErr::fetch(py)?;

I likePyErr::fetch() -> Option<PyErr> as well, it does seem to map better to the underlying api as you've noted.

@davidhewitt
Copy link
Member Author

(Thanks for the comments, continued on #1957)

@davidhewitt
Copy link
Member Author

#1957 is merging soon, I will rebase this PR and prepare the release tomorrow.

@davidhewitt
Copy link
Member Author

Rebased on main and intend to release this evening. Thanks for patience everyone.

@davidhewitt
Copy link
Member Author

Release is live!

@davidhewitt davidhewitt merged commit 00c84eb into main Nov 3, 2021
@davidhewitt davidhewitt deleted the release-0.15 branch November 20, 2021 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.15 Release
4 participants