Pypy hasattr #2025
Merged
Pypy hasattr #2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The first commit here looks unrelated? |
Is removed now. was a leftover from testing. rust-numpy does not support the latest pyo3 version (or at least I couldn't get it to work). |
ghuls
added a commit
to ghuls/polars
that referenced
this pull request
Nov 25, 2021
Add support for compiling polars for PyPy:
- requires newer version of maturin
- requires pyo3 0.15.1 with the following patch:
Map "PyPyObject_HasAttr" to "PyObject_HasAttr" so hasattr works with PyPy:
- PyO3/pyo3#2025
- Available at: https://github.com/ghuls/pyo3/tree/pypy_hasattr
- Patch against latest commits on https://github.com/PyO3/pyo3
won't work for now, as rust-numpy 0.15 is not compatible with
that version yet.
ritchie46
pushed a commit
to pola-rs/polars
that referenced
this pull request
Nov 25, 2021
Add support for compiling polars for PyPy:
- requires newer version of maturin
- requires pyo3 0.15.1 with the following patch:
Map "PyPyObject_HasAttr" to "PyObject_HasAttr" so hasattr works with PyPy:
- PyO3/pyo3#2025
- Available at: https://github.com/ghuls/pyo3/tree/pypy_hasattr
- Patch against latest commits on https://github.com/PyO3/pyo3
won't work for now, as rust-numpy 0.15 is not compatible with
that version yet.
davidhewitt
approved these changes
Nov 25, 2021
CHANGELOG.md
Outdated
| @@ -21,6 +21,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|
|||
| - Add `Py::setattr` method. [#2009](https://github.com/PyO3/pyo3/pull/2009) | |||
| - Add `PyCapsule`, exposing the [Capsule API](https://docs.python.org/3/c-api/capsule.html#capsules). [#1980](https://github.com/PyO3/pyo3/pull/1980) | |||
| - Map `PyPyObject_HasAttr` to `PyObject_HasAttr` so `hasattr` works with PyPy. [#2025](https://github.com/PyO3/pyo3/pull/2025) | |||
There was a problem hiding this comment.
I'm going to force-push to move this to the ## Fixed section.
…PyPy. Map "PyPyObject_HasAttr" to "PyObject_HasAttr" so hasattr works with PyPy. Solves: "undefined symbol: PyObject_HasAttr" when importing the library.
davidhewitt
force-pushed
the
pypy_hasattr
branch
from
a0b70c6 to
5ecc715
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to pyo3!
Please consider adding the following to your pull request:
Be aware the CI pipeline will check your pull request for the following:
cargo testormake testif you need to test examples)make clippy)cargo fmt)black . --check. You can install black withpip install black)tox; you can do run it usingmake test_py.You can run a similar set of checks as the CI pipeline using
make test.