-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: 0.16.4 #2290
release: 0.16.4 #2290
Conversation
5edb645
to
70a56be
Compare
Thanks, it would be cool to add #2263 to this too |
Yes, I think that would make sense. Will rebase when that PR is merged. |
@davidhewitt Keeping with the theme of reducing busy work, I tried drafting a GitHub release for you to review before publishing. Is there a command or script you use to generate the list of contributors? |
Thanks! No script; I just use the GitHub UI v0.16.3...HEAD Every time I do it I think I should write a script and then never find the time 😂 |
https://gist.github.com/adamreichold/b62493c129a55c0929b742990acb4185 appears to work. If it turns out to be helpful, maybe it can get a more permanent place of residence (and some amenities like error checking). |
Nice! Yes I think it's fine to commit it somewhere to the repo. |
70a56be
to
a1150a0
Compare
Rebased and updated the draft release. |
Thanks! I didn't push this yesterday in the end because I wanted to wait until after 0.15.2 published. I couldn't remember if I pushed this and then 0.15.2 whether crates.io would list 0.16.4 or 0.15.2 as the latest version. |
a1150a0
to
f0cec78
Compare
Force-pushed to update the date. |
f0cec78
to
d2caa05
Compare
Rebased a final time to pick up #2293 |
Release is live. Thanks again @adamreichold for all the work writing fixes, reviewing, and preparing this release 👍 |
I fear we might have regressed w.r.t. finding the Python interpreter: https://github.com/PyO3/rust-numpy/runs/6029114285?check_suite_focus=true |
It might also be Maturin, because the part where
seems wrong as the crate does not use the stable ABI. |
I added a changelog entry for the coverage change because PyO3/rust-numpy#316 revealed that this also affects downstream crates depending on PyO3.
@davidhewitt Hopefully, this reduces the busy work for you a bit.