Allow #[classattr] methods to be fallible
#2385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
force-pushed
the
classattr-results
branch
from
75a6b78 to
645600a
Compare
davidhewitt
force-pushed
the
classattr-results
branch
from
645600a to
0de0e3f
Compare
|
Anyone got any concerns before I merge this? I don't think it's essential at all, just seems like a sensible refinement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this morning while looking at #2382 that it's not possible to return
PyResultfrom#[classattr]methods.There's not much we can do with them but panic, but it is at least a nice consistency change to match other
#[pymethods].