Do not store return values in locals so that holders benefit from lifetime extension for temporaries. #3142
Conversation
adamreichold
force-pushed
the
extend-holder-lifetime-the-giant-tail-expression-edition
branch
from
6a5e7eb to
a60945f
Compare
There was a problem hiding this comment.
Thanks, as discussed on #3140, let's move ahead with this solution. I won't merge just in case you want to play with refactoring the OkWrap pattern into a function or struct as suggested on that thread. (I am also fine with leaving that for the future, the macro code will be simpler once we ditch the deprecated #[args] and also I have a refactoring or two in my mind which maybe I'll get to one day.)
I'd like to limit ourselves to the fix for now as I am seeing an obvious simplification by trying to extract the ok wrapping ATM. bors r=davidhewitt |
3142: Do not store return values in locals so that holders benefit from lifetime extension for temporaries. r=davidhewitt a=adamreichold Closes #3138 Co-authored-by: Adam Reichold <[email protected]>
|
bors retry |
|
Already running a review |
|
Build failed: |
|
bors retry |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
bors
bot
deleted the
extend-holder-lifetime-the-giant-tail-expression-edition
branch
Closes #3138