Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NULL pointer deref when creating iterator for non-iterable #558

Merged
merged 1 commit into from
Aug 5, 2019
Merged

Fix NULL pointer deref when creating iterator for non-iterable #558

merged 1 commit into from
Aug 5, 2019

Conversation

danieldk
Copy link
Contributor

Fixes #494.

@danieldk
Copy link
Contributor Author

Sorry, missed #544.

@danieldk danieldk closed this Jul 27, 2019
@konstin konstin reopened this Aug 5, 2019
@codecov
Copy link

codecov bot commented Aug 5, 2019

Codecov Report

Merging #558 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #558      +/-   ##
==========================================
+ Coverage   87.61%   87.62%   +<.01%     
==========================================
  Files          65       65              
  Lines        3449     3451       +2     
==========================================
+ Hits         3022     3024       +2     
  Misses        427      427
Impacted Files Coverage Δ
src/types/iterator.rs 89.47% <100%> (+1.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 382c79e...ac28a31. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Aug 5, 2019

Codecov Report

Merging #558 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #558      +/-   ##
==========================================
+ Coverage   87.61%   87.62%   +<.01%     
==========================================
  Files          65       65              
  Lines        3449     3451       +2     
==========================================
+ Hits         3022     3024       +2     
  Misses        427      427
Impacted Files Coverage Δ
src/types/iterator.rs 89.47% <100%> (+1.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 382c79e...ac28a31. Read the comment docs.

@konstin
Copy link
Member

konstin commented Aug 5, 2019

Since this passes ci an #544 doesn't, I'm going to take this until we figure what makes #544 fail.

@sebpuetz
Copy link
Contributor

@konstin could you cherrypick this change on 0.7 or release a new minor version including this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SIGSEGV when PyIterator is given an integer
3 participants