-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump dependency on cfg-if #240
Conversation
Note that this bumps MSRV (I can't remember to what). PyO3 was blocked on updating to 1.0 until we recently raised MSRV to 1.48 (for upcoming 0.16 release). So this might not want to merge until we're ready to release 0.16 here too? |
Ouch, sorry for not having this on the radar! So I think this meshes with the discussion in #236 (comment) and I think the best course would be to declare the Would that be alright with you @kngwyu ? If so, we could merge this into |
I agree with the release of 0.15.1, but I don't think this PR is so urgent... Just waiting for a bit can be simpler, though I don't know the release plan of PyO3 0.16 |
Only if we decide to decouple the version numbers of PyO3 and rust-numpy as we already have breaking changes on |
Ah OK, then I think your strategy is better. |
I pushed another commit here which aligns our MSRV on the |
…on into other crates dependency tree.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks again!
So that we do not pull in the pre-1.0 version into other crates dependency tree.