Add PyArrayDescr::new()
#266
Merged
+45
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #266 +/- ##
==========================================
+ Coverage 81.38% 81.66% +0.27%
==========================================
Files 14 14
Lines 1531 1554 +23
==========================================
+ Hits 1246 1269 +23
Misses 285 285
Continue to review full report at Codecov.
|
aldanor
force-pushed
the
feature/pydescr-new
branch
from
e286734
to
1ca261a
Compare
adamreichold
requested changes
Jan 24, 2022
aldanor
force-pushed
the
feature/pydescr-new
branch
2 times, most recently
from
7c3ed39
to
1e45082
Compare
|
Rebased on main, fixed signature, simplified null check, updated the changelog. |
aldanor
force-pushed
the
feature/pydescr-new
branch
from
1e45082
to
8b354b6
Compare
aldanor
force-pushed
the
feature/pydescr-new
branch
from
8b354b6
to
436ec9a
Compare
adamreichold
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides the same functionality as invoking
np.dtype()from within Python (except that passingNonewouldn't yield float64 by default - but if we really want that for some reason, it can be changed).