disable pyo3's gil-refs
migration feature
#420
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This disables
pyo3
sgil-ref
migration feature, and fixes all the deprecations that are still left.One major change to note is in
PyArrayDescr::names
, which I changed to return aVec<PyBackedStr>
instead ofVec<&str>
. I don't think we can support the old signature anymore without gil-refs.I noticed here that
PyBacked*
does not implementDebug
. Maybe we should add one inpyo3
(which could just delegate to the debug of theDeref::Target
). SomePartialEq
/Eq
impls could also be nice I think. cc @davidhewitt