-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace bioenergy stores with generators #1372
Open
cpschau
wants to merge
51
commits into
ariadne2
Choose a base branch
from
e_sum_generators
base: ariadne2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+50
−86
Open
Changes from 4 commits
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
7798e12
feat: add temperature reduction to workflow
amos-schledorn c252d17
chore: fix name change issues
amos-schledorn a83909c
feat: update input/output of dependent rules
amos-schledorn 31e6e3a
feat: add {planning _horizons} wildcard to COP input in myopic rules
amos-schledorn 85656c0
fix: exponential temperature reduction
amos-schledorn 881cf01
feat: add {planning_horizons} wildcard to solve_perfect
amos-schledorn cdfcf23
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 69cad8e
style: "_today" -> "_baseyear"
amos-schledorn 39ae475
doc: update configtables
amos-schledorn d5c6135
style: "_today" -> "_baseyear" (config)
amos-schledorn 6c112e3
Merge remote-tracking branch 'origin/annual-temperature-reduction' in…
amos-schledorn a109899
feat: update heat pump efficiency in add_brownfield
amos-schledorn d218a08
Merge remote-tracking branch 'origin/master' into annual-temperature-…
amos-schledorn a5be8b4
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 7bf57ad
fix: pass planning_horizons to add_brownfield
amos-schledorn 94d628f
Merge branch 'master' into annual-temperature-reduction
amos-schledorn 8871a2d
feat: update COPs for perfect foresight
amos-schledorn 4107e31
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 30f7dce
update release notes
amos-schledorn bf87e8c
Merge remote-tracking branch 'origin/annual-temperature-reduction' in…
amos-schledorn 635d3d6
Update doc/release_notes.rst
amos-schledorn f1f0d20
Update scripts/build_central_heating_temperature_profiles/run.py
amos-schledorn ecbb228
Update scripts/build_central_heating_temperature_profiles/run.py
amos-schledorn bdf1d7d
Merge branch 'master' into annual-temperature-reduction
amos-schledorn 85a878b
Update build_central_heating_temperature_profiles.run
amos-schledorn b27227f
style: simplify update_heat_pump_efficiency functions
amos-schledorn a9853b0
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 9950384
Merge branch 'master' into annual-temperature-reduction
amos-schledorn 5095a74
Update README.md
fneum 267e540
[pre-commit.ci] pre-commit autoupdate (#1352)
pre-commit-ci[bot] 2e6132c
Merge branch 'master' into annual-temperature-reduction
fneum b9416ae
transmission_projects: update AC line types to high-temperature lines…
p-glaum 6dd41b8
Bugfix of solar constraint in post discretization (#1343)
toniseibold 5402088
Merge pull request #1290 from PyPSA/annual-temperature-reduction
amos-schledorn 5fa8007
Update NEP DC20 to underground
nworbmot 4435f02
fix: remove broken pre-commit rule (docformatter) (#1362)
lkstrp 0e0191a
prepare for pypsa `0.31.0` (#1340)
lkstrp be83b59
[github-actions.ci] Update fixed environment (#1363)
github-actions[bot] 0026b0f
fix: more robust `progress_retrieve` (#1361)
lkstrp 236a1fb
replace bioenergy stores with generators
cpschau 006eb3c
fix values to ensure feasibility
cpschau 029ff85
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 9edf5b1
replace bioenergy stores with generators
cpschau 9bb42c8
fix values to ensure feasibility
cpschau f7dad98
represent other bioenergy and msw sources as generators
cpschau eded450
fix spatial variable for biogas
cpschau 51f651c
fix virtual msw transport bug
cpschau adcf3d3
make operational limit for msw work
cpschau 42c262e
Merge branch 'ariadne2' into e_sum_generators
lindnemi 39b154f
fix bioliquids potential resolution
cpschau 5237167
Merge remote-tracking branch 'origin/replace_stores_gens' into e_sum_…
lindnemi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is the right constraint. There is one generator for every bus, and if every bus has access to the sum of the total potential wouldn't we get
n_buses * total_potential
of import capacity?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah i see, the GlobalConstraint is just below and remains there. Then the questions if, if this e_sum_max constraint is still needed or only a duplicate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you are right that it is not only redundant, but actually false. The e_sum_max set at the original generator intialization in
pypsa-eur/scripts/prepare_sector_network.py
Line 2913 in 42c262e