Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: exporting gdp_pop to geojson. #1388

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Bug fix: exporting gdp_pop to geojson. #1388

merged 1 commit into from
Oct 23, 2024

Conversation

bobbyxng
Copy link
Contributor

Changes proposed in this Pull Request

  • Bug fix: Changing snakemake.output to snakemake.output[0], as snakemake.output returns a list, even if only one entry exists. gpd.to_file() however requires a string.
  • Workflow tested and running
  • Only relevant for MD; UA; and XK

Checklist

  • I tested my contribution locally and it works as intended.

@bobbyxng bobbyxng requested a review from lkstrp October 23, 2024 12:06
@bobbyxng bobbyxng self-assigned this Oct 23, 2024
@lkstrp lkstrp merged commit 8743ff9 into master Oct 23, 2024
6 of 12 checks passed
Copy link
Contributor

github-actions bot commented Oct 23, 2024

Validator Report

I am the Validator. Download all artifacts here.
I'll be back and edit this comment for each new commit.

General

Plots comparison
Main branch Feature branch
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Files comparison
Status NRMSE MAE (norm)
prices.csv ⚠️Changed 0.000 0.10
weighted_prices.csv ⚠️Changed 0.553 0.42
market_values.csv ⚠️Changed 0.001 0.05
price_statistics.csv ⚠️Changed 0.000 0.29
metrics.csv ⚠️Changed 0.000 0.07
cfs.csv ⚠️Changed 0.028 0.05
curtailment.csv ⚠️Changed 0.000 0.12
nodal_cfs.csv ✅ Almost equal 0.068 0.02
nodal_costs.csv ✅ Almost equal 0.002 0.00
nodal_capacities.csv ✅ Almost equal 0.000 0.00
supply.csv ✅ Almost equal 0.000 0.02
nodal_supply_energy.csv ✅ Almost equal 0.000 0.00
costs.csv ✅ Almost equal 0.000 0.01
capacities.csv ✅ Almost equal 0.000 0.03
supply_energy.csv ✅ Almost equal 0.000 0.02
energy.csv ✅ Almost equal 0.000 0.02

NRMSE: Normalized (combined-min-max) Root Mean Square Error
MAE (norm): Mean Absolute Error on normalized data (min-max)
Status Threshold: MAE (norm) > 0.05 and NRMSE > 0.3

Model Metrics

Benchmarks Image not available Image not available Image not available

Comparing fix-build-gdp-pop (0a237a3) with master (fc2972d).
Branch is 1 commits ahead and 0 commits behind.
Last updated on 2024-10-23 14:31:31 CEST.

lindnemi added a commit that referenced this pull request Oct 24, 2024
* Bug fix: simplify_network.py (simplify_links) - By adding preceding converter removal (#1381)

* Implemented simplify_links fix by adding a preceding function removing converters.

* Added release_notes.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Dropped manual configfile.

* Cleaned up code.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Bug fix: simplify_network.py (simplify_links) - By adding preceding converter removal (#1381)

* Implemented simplify_links fix by adding a preceding function removing converters.

* Added release_notes.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Dropped manual configfile.

* Cleaned up code.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Updated to osm-network version 0.5

* Added sources to doc/data_sources.rst

* Bug fix, exporting gdp_pop to geojson. (#1388)

* tech-colors for gas primary and compressing

---------

Co-authored-by: Bobby Xiong <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: bobbyxng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants