-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce hierarchical agglomeratice clustering (hac) #293
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
So HAC will be the new default? Could you highlight this in a release note? It's quite a significant change.
Two maps with clustered regions (~200 nodes) with previous k-means default and new HAC defaults would also very nicely complement this PR. Do you have something like that at hand?
thanks @fneum for suggestions and improvements for the code, should all be in. However, I want to make a change to the network "topology" sort-of and change two country-labels of n.buses. I'll do this in a new PR (somewhat cleaner), but the new PR should be in before this one. I'll add some figs and definitely a note for the release_notes as well! |
and, as requested, here are some plots for comparison (k-meas vs. hac-time) for different spatial resolutions: hac-time+kmeans_50.pdf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! But I still had a few comments and suggestions for improvements. Could you also add a release note with two or three sentences how to use it and what to keep in mind?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to merge this.
Although I've been thinking about whether it would be wise to first introduce this new feature and then make it a default in the version after the next. This would just mean changing the default config from hac
to kmeans
. What do you think @FabianHofmann @martacki?
@martacki could you also add a few lines and instructions to the release notes?
Yes I agree we shouldn't change default in the same go as we introduce the new clustering, just to be on the safer side. Changed to old default. |
Integrate linopy as solver framework
Changes proposed in this Pull Request
...story continues...
Introduce hierarchical agglomeraticve clustering method into pypsa-eur, now that it is (finally) included in PyPSA PyPSA/PyPSA#289.
(additional) changes:
Locally the function(s) worked fine.
Checklist
envs/environment.yaml
andenvs/environment.docs.yaml
.config.default.yaml
,config.tutorial.yaml
, andtest/config.test1.yaml
.doc/configtables/*.csv
and line references are adjusted indoc/configuration.rst
anddoc/tutorial.rst
.doc/release_notes.rst
is amended in the format of previous release notes.