Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nlpo3.load_dict() that never print error msg when not success #979

Merged
merged 2 commits into from
Nov 3, 2024
Merged

Fix nlpo3.load_dict() that never print error msg when not success #979

merged 2 commits into from
Nov 3, 2024

Conversation

bact
Copy link
Member

@bact bact commented Nov 3, 2024 •
edited
Loading

The check should be if not success not if bool is False which will always False.

@bact bact added the bug bugs in the library label Nov 3, 2024
@bact bact merged commit ef4b703 into PyThaiNLP:dev Nov 3, 2024
19 of 20 checks passed
@bact bact deleted the fix-nlpo3-bool-bug branch November 3, 2024 19:36
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@bact bact changed the title Fix success check in nlpo3.load_dict Fix nlpo3.load_dict() that never print error msg when not success Nov 3, 2024
@bact bact mentioned this pull request Nov 3, 2024
Open
@coveralls
Copy link

Coverage Status

coverage: 51.837% (-0.05%) from 51.89%
when pulling 26082f7 on bact:fix-nlpo3-bool-bug
into ed83a18 on PyThaiNLP:dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug bugs in the library
Projects
PyThaiNLP
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bact @coveralls