-
-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for custom status #2206
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dorukyum
added
priority: medium
Medium Priority
status: in progress
Work in Progess
feature
Implements a feature
API Reflection
Discords API wasn't correctly reflected in the lib
changelog needed
labels
Aug 9, 2023
Dorukyum
added
status: awaiting review
Awaiting review from a maintainer
and removed
status: in progress
Work in Progess
changelog needed
labels
Aug 10, 2023
Lulalaby
previously approved these changes
Aug 14, 2023
Signed-off-by: Dorukyum <[email protected]>
This reverts commit cf5f771.
activity = discord.CustomActivity("I'm Batman.") This will have the same effect as: activity = discord.Activity(type=discord.ActivityType.custom, state="I'm Batman.") |
LGTM |
Lulalaby
reviewed
Aug 17, 2023
Lulalaby
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
API Reflection
Discords API wasn't correctly reflected in the lib
feature
Implements a feature
priority: medium
Medium Priority
status: awaiting review
Awaiting review from a maintainer
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2204.
Defaults
Activity.name
to"Custom Status"
if the type isActivityType.custom
when initializing, but not sure if this is the best way to do it. This currently requires developers to explicitly set thetype
field toActivityType.custom
because it defaults toActivityType.unknown
, as seen in the example below:I feel like this should be made easier on the developer frontend, resulting with the following:
I'm ready to push the change necessary to implement the last suggestion if the idea is approved.
Information
examples, ...).
Checklist
type: ignore
comments were used, a comment is also left explaining why.