Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PhaseSpaceDefiniton #140

Open
szabo137 opened this issue Nov 15, 2024 · 0 comments
Open

Remove PhaseSpaceDefiniton #140

szabo137 opened this issue Nov 15, 2024 · 0 comments
Assignees

Comments

@szabo137
Copy link
Member

szabo137 commented Nov 15, 2024

The usage of PhaseSpaceDefinion and its interface should be deprecated in favor of AbsrtactPhaseSpaceLayout. This also includes removing AbstractFrameOfReference and AbstractCoordinateSystem because they are better described by PhaseSpaceLayouts.

This would make #113 obsolete.

@szabo137 szabo137 changed the title Streamline PhaseSpaceLayout Remove PhaseSpaceDefiniton Nov 15, 2024
AntonReinhard added a commit that referenced this issue Jan 20, 2025
With this PR, I propose a major refactoring of the test implementation,
mostly to drop `QEDcore.jl` as a test dependency. See #144 for details.

## TODO (unit tests itself)

- [x] particle: check only particle properties
- [x] particle: implement and check `propagator` 
- [x] particle: implement and check `base_state`
- [x] process: moving parts that do not belong to processes (marked in
the code by `TODO`)
- [x] particle stateful: implement some tests
- [x] cross section: remove coordinate-based evaluation (is checked in
PSP tests)
- [x] core_compat: move to `QEDcore.jl`

## TODO (test implementation)

- [x] psp: make `TestPhaseSpacePoint(...,moms)` type-stable
- [x] psp: implement proper in- and out-psps
- [x] particle: implement massless particles
- [x] psl: implement failing PSL

## TODO (general)

- [x] consider testing everything for `(TestMomentum{T},
TestMomentumMutable{T})` where `T<:Union{Float16,Float32, Float64}` (not
just for `TestMomentum{Float64}`)


## Final remarks

Solves #144. 

Makes #140 easier to achive.

---------

Co-authored-by: Uwe Hernandez Acosta <[email protected]>
Co-authored-by: Anton Reinhard <[email protected]>
@AntonReinhard AntonReinhard self-assigned this Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants