Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GPU incompatability of momenta implementation #111

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

AntonReinhard
Copy link
Member

Rewrite momenta function without broadcast, because GPUs do not like broadcasts in their kernels.
This is essentially ported from QEDjl-project/QEDprocesses.jl#69 since this implementation moved here since that PR was opened.

@AntonReinhard AntonReinhard requested a review from szabo137 August 9, 2024 12:25
Copy link
Member

@szabo137 szabo137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me! Many thanks for that!

@AntonReinhard AntonReinhard merged commit 03af046 into QEDjl-project:dev Aug 9, 2024
4 checks passed
@AntonReinhard AntonReinhard deleted the gpu-compatability branch August 9, 2024 13:46
@AntonReinhard AntonReinhard added this to the Release-next milestone Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants