Add Synced Spins and Polarizations #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonReinhard
force-pushed
the
103-synced-spinpol
branch
from
4d81797 to
9bf3ffa
Compare
szabo137
reviewed
Aug 13, 2024
There was a problem hiding this comment.
I really like the idea and have just minor concerns.
TL;DR:
Especially the possibility to only iterate over "valid" spin/pol combinations seems very powerful. This will come in handy, if we start implementing the helicity amplitudes: https://arxiv.org/abs/hep-ph/9805445
AntonReinhard
force-pushed
the
103-synced-spinpol
branch
from
8b7b034 to
2dfae74
Compare
szabo137
approved these changes
Aug 15, 2024
SimeonEhrig
pushed a commit
to QEDjl-project/QEDprocesses.jl
that referenced
this pull request
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #103
This adds the
SyncedPolarization{N}andSyncedSpin{N}types proposed in #103 and reworks themultiplicityfunction to work onAbstractProcessDefinitions instead of raw spins or pols, since this previous notion ofmultiplicitydoes not extend to synced spins/pols.The new implementation of
multiplicityis faster than theprod.(spins_pols)that was used previously, because it can be compiled away when the spins and pols of the process are known at compile time.This update breaks QEDprocesses and will require a tiny update there.