Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Beautification and docs #127

Merged
merged 23 commits into from
Oct 21, 2024
Merged

Conversation

szabo137
Copy link
Member

@szabo137 szabo137 commented Sep 30, 2024

  • Fix jldoctests
  • finish API reference
  • Write tutorial for PSP
  • Write tutorial for stateful particles
  • Write tutorial for Lorentz vectors
  • Write tutorial for particle interface
  • Write tutorial for processes

@AntonReinhard
Copy link
Member

Looking at the documentation of the propagator, it seems outdated. It says the mass of the particle is assumed to be zero if it is not given, but QEDcore never accepts a mass parameter at all. I think it does (and should) get the mass from the passed particle type's mass. So it might be a good idea to update the docs while we're at it.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/make.jl Outdated Show resolved Hide resolved
@szabo137
Copy link
Member Author

Since there is not much to say about models (at least not currently), I removed the respective (blank) tutorial page. Similarly, I removed the respective pages for Dirac tensors, because there is not really an interface to talk about. I suggest explaining the Dirac algebra in QEDcore, where it is fully implemented.

From my side, I think this reached a state, where we can consider merging it.

@szabo137 szabo137 marked this pull request as ready for review October 11, 2024 18:49
Copy link
Member

@AntonReinhard AntonReinhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small broken link

docs/src/tutorial/particle_stateful.jl Outdated Show resolved Hide resolved
@szabo137 szabo137 merged commit 579862b into QEDjl-project:dev Oct 21, 2024
4 checks passed
szabo137 added a commit to QEDjl-project/QEDcore.jl that referenced this pull request Oct 22, 2024
In the same spirit as the respective [QEDbase
PR](QEDjl-project/QEDbase.jl#127), this adds
some documentation, orders the functions into a (hopefully more useful)
library category, and adds some manuals for the main features with usage
examples.

- [x] Once the QEDbase PR is merged, the @extref in particles.jl has to
be enabled.

The vectors manual is currently more of a place holder because I don't
know enough about them to write a good manual. I would refer this task
to @szabo137 or @steindev .
The phase space definition manual is also a placeholder, because it will
be reworked soon anyway (see #50).
@AntonReinhard AntonReinhard added this to the Release-0.3.0 milestone Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants