Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added coord trafo interface #129

Merged
merged 4 commits into from
Oct 11, 2024

Conversation

szabo137
Copy link
Member

@szabo137 szabo137 commented Oct 7, 2024

Following the suggestion made here: QEDjl-project/QEDcore.jl#45 (comment)

@szabo137 szabo137 requested a review from AntonReinhard October 7, 2024 14:14
AntonReinhard
AntonReinhard previously approved these changes Oct 11, 2024
Copy link
Member

@AntonReinhard AntonReinhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was mostly reviewed already, just two suggestions from my side

src/QEDbase.jl Outdated Show resolved Hide resolved
src/interfaces/coordinate_transformation.jl Outdated Show resolved Hide resolved
Co-authored-by: Anton Reinhard <[email protected]>
Co-authored-by: Anton Reinhard <[email protected]>
@szabo137 szabo137 merged commit 566e001 into QEDjl-project:dev Oct 11, 2024
4 checks passed
@AntonReinhard AntonReinhard added this to the Release-0.3.0 milestone Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants