Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make format_all.jl path independent #17

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

SimeonEhrig
Copy link
Member

Before the format_all.jl script needs to be execute from the project root directory. Now the script can be executed from every directory path.

- Before the format_all.jl script needs to be execute from the project root directory. Now the script can be executed from every directory path.
Copy link
Member

@szabo137 szabo137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. No concerns from my side.

There is just one minor issue, which is not directly related to this PR: the .formatting/Manifest.yml is outdated and uses Julia==1.8.1, which is not compatible with Julia=1.9 used in the CI. If you want, you can fix this in the current PR, if not, I will open a respective issue.

@SimeonEhrig
Copy link
Member Author

There is just one minor issue, which is not directly related to this PR: the .formatting/Manifest.yml is outdated and uses Julia==1.8.1, which is not compatible with Julia=1.9 used in the CI. If you want, you can fix this in the current PR, if not, I will open a respective issue.

We should discuss it in general, if we should add the Manifest.yml to the repository. I know it make it reproducible but is this required for a library? I found this answer: https://discourse.julialang.org/t/does-manifest-toml-belong-in-the-repository/12029

In my opinion, we should remove it because the reproducibility is not important if we provide the QED packages for other projects/applications. The advantages would be, that we avoid unnecessary warnings with the different Julia versions and it reduce the noise in PRs.

@szabo137
Copy link
Member

As discussed offline, the manifest files will be removed in a separate PR.

@szabo137 szabo137 merged commit e9d19c4 into QEDjl-project:dev Sep 20, 2023
@SimeonEhrig SimeonEhrig added this to the 0.1.5 milestone Oct 18, 2023
szabo137 pushed a commit that referenced this pull request Jan 28, 2024
Before the format_all.jl script needs to be execute from the project
root directory. Now the script can be executed from every directory
path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants