Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add formatter job to GitHub Actions #19

Merged
merged 1 commit into from
Oct 10, 2023
Merged

add formatter job to GitHub Actions #19

merged 1 commit into from
Oct 10, 2023

Conversation

SimeonEhrig
Copy link
Member

No description provided.

@SimeonEhrig SimeonEhrig force-pushed the mvFormattingJobGitHubAction branch from b6428e5 to 9330106 Compare September 26, 2023 06:36
szabo137
szabo137 previously approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@szabo137 szabo137 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, why is the formatting job not triggered on this PR?

@szabo137 szabo137 dismissed their stale review September 26, 2023 07:41

The formatting workflow is not starting.

@SimeonEhrig SimeonEhrig force-pushed the mvFormattingJobGitHubAction branch from 9330106 to 6e26655 Compare September 26, 2023 08:37
@szabo137
Copy link
Member

I guess you could add on: workflow_dispatch to the workflow definition, so we may trigger the job manually (see here for details).

@SimeonEhrig SimeonEhrig force-pushed the mvFormattingJobGitHubAction branch from a85f6a9 to d32bd8f Compare October 9, 2023 15:09
@SimeonEhrig
add formatter job to GitHub Actions
02fddb9 
- Because of a bug in Github Actions, we keep the Gitlab CI job for the moment.
@SimeonEhrig SimeonEhrig force-pushed the mvFormattingJobGitHubAction branch from d32bd8f to 02fddb9 Compare October 10, 2023 07:45
@SimeonEhrig
Copy link
Member Author

@szabo137 Maybe I found the reason, why the Github Workflow is not triggered: https://stackoverflow.com/a/77161850/22035743
Maybe the workflow will be triggered the first time, if we merge in dev and open a new repository. Therefore, the PR only adds the GitHub formatter job and keeps the GitLab CI formatter job for the moment.

If everything is working, I remove the GitLab CI formatter in a following up PR:

@SimeonEhrig SimeonEhrig changed the title move formatter job to GitHub Actions add formatter job to GitHub Actions Oct 10, 2023
@szabo137
Copy link
Member

Since this PR is not breaking any functionality of the package, I will follow @SimeonEhrig suggestion to merge it into dev, and see if the action is triggered for formatting.

@szabo137 szabo137 merged commit c1b7a21 into QEDjl-project:dev Oct 10, 2023
@SimeonEhrig SimeonEhrig added this to the 0.1.5 milestone Oct 18, 2023
@szabo137 szabo137 mentioned this pull request Jun 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szabo137 szabo137 szabo137 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release-0.1.5
Development

Successfully merging this pull request may close these issues.
2 participants
@SimeonEhrig @szabo137