Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run unit tests for Julia 1.6 until 1.9 #29

Merged
merged 1 commit into from
Oct 16, 2023
Merged

run unit tests for Julia 1.6 until 1.9 #29

merged 1 commit into from
Oct 16, 2023

Conversation

SimeonEhrig
Copy link
Member

@SimeonEhrig SimeonEhrig commented Oct 10, 2023 •
edited
Loading

  • tests also the latest unreleased version 1.10 (can fail)
  • integration tests still testing a single version. Will be extended in another PR.

@SimeonEhrig SimeonEhrig force-pushed the manyVersionUnitTest branch 2 times, most recently from c3fe0a3 to b07914d Compare October 10, 2023 14:47
@SimeonEhrig
Copy link
Member Author

@szabo137 What do you think. The Unit tests passed successful version 1.6 until 1.9: https://gitlab.com/hzdr/qedjl-project/QEDbase-jl/-/pipelines/1032135149

Version 1.10 failed, but this is okay for the CI: https://gitlab.com/hzdr/qedjl-project/QEDbase-jl/-/jobs/5262079422

@SimeonEhrig SimeonEhrig mentioned this pull request Oct 11, 2023
Closed
szabo137
szabo137 previously approved these changes Oct 14, 2023
View reviewed changes
Copy link
Member

@szabo137 szabo137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was a bit more lenient about the Julia versions which should be checked. Are those runs executed in parallel, or might this add time to the ci-runs?

.gitlab-ci.yml Outdated Show resolved Hide resolved
@szabo137
Copy link
Member

BTW: nightly fails are fine. These bugs will become a problem if nightly becomes stable, and this will be the time when we need to do something - before we can do it.

@SimeonEhrig
run unit tests for Julia 1.6 until 1.9
75bae12 
- run also test with nightly version (can fail)
szabo137
szabo137 approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@szabo137 szabo137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All conversations are resolved, no additional concerns, ready for merging!

@szabo137 szabo137 merged commit 1643de9 into QEDjl-project:dev Oct 16, 2023
@SimeonEhrig SimeonEhrig added this to the 0.1.5 milestone Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szabo137 szabo137 szabo137 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release-0.1.5
Development

Successfully merging this pull request may close these issues.
2 participants
@SimeonEhrig @szabo137