Base state fix #37
Merged
Base state fix #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonReinhard
requested review from
szabo137,
SimeonEhrig,
steindev and
tjungni
AntonReinhard
force-pushed
the
base_state_fix
branch
from
95b4c23 to
94e34e6
Compare
szabo137
approved these changes
Oct 18, 2023
steindev
approved these changes
Oct 19, 2023
tjungni
approved these changes
Oct 19, 2023
Closed
szabo137
pushed a commit
that referenced
this pull request
Jan 28, 2024
Fix base_state for AllPol and AllSpin Provide a way to consistently get an SVector from the return value of base_state --------- Co-authored-by: Rubydragon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal for a fix to #36