Improve parameter coverage in particle unit test #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimeonEhrig
reviewed
Dec 14, 2023
SimeonEhrig
approved these changes
Dec 14, 2023
szabo137
added a commit
that referenced
this pull request
Jan 28, 2024
This PR improves the coverage for coordinates tested in `test/particle.jl` to the full domains for angles in spherical coordinates for photons. - added safetestsets to modulize the unit tests - added more cases for the angles in spherical coordinates - added a fix for #49 This resolves #49 --------- Co-authored-by: Uwe Hernandez Acosta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the coverage for coordinates tested in
test/particle.jlto the full domains for angles in spherical coordinates for photons.Summary
This resolves #49