Add is_incoming and is_outgoing to exports #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added a PR in QED.jl to fix the integration test generator which is currently broken here: QEDjl-project/QuantumElectrodynamics.jl#31 |
|
Thanks for this! I see the issue with the integration tests. I think we need to wait until QEDjl-project/QuantumElectrodynamics.jl#31 is merged. Then we can trigger the test again and proceed with this one. (Btw. Many thanks for providing the fix for the integration test bug in the first place 👌) |
|
@szabo137 If there are no more problems, please approve and merge |
szabo137
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They were missing from the exports so I added them.