Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BiSpinor multiplication fix for GPU #64

Merged
merged 1 commit into from
May 27, 2024
Merged

BiSpinor multiplication fix for GPU #64

merged 1 commit into from
May 27, 2024

Conversation

AntonReinhard
Copy link
Member

Just a tiny for multiplication of BiSpinor * AdjointBiSpinor on GPU. The general dot product doesn't work on the GPU.

@AntonReinhard AntonReinhard mentioned this pull request May 24, 2024
Draft
6 tasks
szabo137
szabo137 approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@szabo137 szabo137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me.

More general question: Isn't this a problem in the other multiplications as well? And what is the actual problem? The transpose function or the *(...,...)?

Could you please open an issue, that we need the GPU tests to catch such bugs.

@szabo137 szabo137 removed the request for review from steindev May 27, 2024 11:51
@AntonReinhard AntonReinhard mentioned this pull request May 27, 2024
Open
@AntonReinhard
Copy link
Member Author

I think the issue is the product which iterates. I opened an issue in QEDjl-project/QEDcore.jl#89

@AntonReinhard AntonReinhard merged commit 4b22825 into QEDjl-project:dev May 27, 2024
4 checks passed
@AntonReinhard AntonReinhard deleted the fix_bs_multiplication branch May 27, 2024 12:42
@szabo137 szabo137 added this to the Release-next milestone Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szabo137 szabo137 szabo137 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release-0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@AntonReinhard @szabo137