Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pretty printing #65

Merged
merged 1 commit into from
May 27, 2024

Conversation

AntonReinhard
Copy link
Member

As discussed in QEDjl-project/QEDprocesses.jl#60 the pretty printing should overload the 2 argument versions of Base.show instead of the 3 argument versions. This PR fixes that for QEDbase.jl

@AntonReinhard AntonReinhard requested a review from szabo137 May 27, 2024 11:44
Copy link
Member

@szabo137 szabo137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me.

More general: in the upcoming restructuring, we should collect all the Base.show implementations in a separate file instead of scattering them around.

@AntonReinhard AntonReinhard merged commit 7020dc7 into QEDjl-project:dev May 27, 2024
4 checks passed
@AntonReinhard AntonReinhard deleted the pretty_printing branch May 27, 2024 12:41
@szabo137 szabo137 added this to the Release-next milestone Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants