Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process distribution interface #33

Merged
merged 4 commits into from
Jul 12, 2024

Conversation

szabo137
Copy link
Member

@szabo137 szabo137 commented Jul 9, 2024

This PR adds an interface for distributions associated with the triple scattering processes, compute models, and phase space definitions. The samples of these distributions are QEDcore.PhaseSpacePoints.

Summary of the changes/adds:

  • New root type for ParticleSampleable with ProcessLikeVariate (already part of QEDevents): ScatteringProcessSampler
  • states the required accessor functions for processes, models, and phase space definition
  • adds respective _assert_valid_input_type
  • adds respective Base.eltype
  • adds respective Distributions.rand based on _randmom
  • adds respective unit tests

Additionally, some rearrangements are done as well.

@szabo137 szabo137 requested a review from AntonReinhard July 9, 2024 19:11
Copy link
Member

@AntonReinhard AntonReinhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Can't wait to us this together with QEDprocesses 👍

@AntonReinhard AntonReinhard merged commit 4091128 into QEDjl-project:dev Jul 12, 2024
4 checks passed
@AntonReinhard AntonReinhard added this to the Release-0.1.0 milestone Aug 6, 2024
@szabo137 szabo137 mentioned this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants