Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use base_state from core #30

Merged
merged 3 commits into from
Jun 20, 2024
Merged

Conversation

szabo137
Copy link
Member

With this PR, QEDfields should use base_state from QEDcore, not from QEDbase.

This is part of the general restructuring of QED.jl, see QEDjl-project/QuantumElectrodynamics.jl#35 for details.

@szabo137 szabo137 requested a review from AntonReinhard June 19, 2024 21:31
AntonReinhard
AntonReinhard previously approved these changes Jun 19, 2024
@szabo137 szabo137 marked this pull request as draft June 19, 2024 21:47
@AntonReinhard
Copy link
Member

AntonReinhard commented Jun 20, 2024

I believe QEDprocesses should be removed from the dependencies now too, right?
Edit: Ah, the Phase Space objects have not moved yet from processes

@szabo137 szabo137 marked this pull request as ready for review June 20, 2024 09:34
@szabo137 szabo137 merged commit ad8f6b9 into QEDjl-project:dev Jun 20, 2024
4 checks passed
@AntonReinhard AntonReinhard added this to the Release-0.1.0 milestone Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants