-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model and Process interface #11
Merged
tjungni
merged 21 commits into
QEDjl-project:dev
from
szabo137:dev-model_and_process_interface
Sep 21, 2023
Merged
Model and Process interface #11
tjungni
merged 21 commits into
QEDjl-project:dev
from
szabo137:dev-model_and_process_interface
Sep 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@tjungni you might also have a look at this. |
szabo137
force-pushed
the
dev-model_and_process_interface
branch
from
September 20, 2023 08:56
7bc8385
to
a11a87b
Compare
Co-authored-by: Tom Jungnickel <[email protected]>
Co-authored-by: Tom Jungnickel <[email protected]>
added process interface and tests added combined interface added differential cross section interface for abstract processes and models, as well as included tests of the interface replaced the hard and soft interfaces by just the registration of the function name. Added the respective doc string to indicate the implementations to be for the interfaces. added doc strings to the functions of the process and model interface. Added an section to the README.md on how-to build the documentation locally.
szabo137
force-pushed
the
dev-model_and_process_interface
branch
from
September 20, 2023 09:32
a11a87b
to
531ed7f
Compare
szabo137
changed the title
[WIP] Model and Process interface
Model and Process interface
Sep 20, 2023
SimeonEhrig
previously approved these changes
Sep 20, 2023
tjungni
reviewed
Sep 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly typos
Co-authored-by: Tom Jungnickel <[email protected]>
Co-authored-by: Tom Jungnickel <[email protected]>
Co-authored-by: Tom Jungnickel <[email protected]>
Co-authored-by: Tom Jungnickel <[email protected]>
Co-authored-by: Tom Jungnickel <[email protected]>
Co-authored-by: Tom Jungnickel <[email protected]>
Co-authored-by: Tom Jungnickel <[email protected]>
Co-authored-by: Tom Jungnickel <[email protected]>
Co-authored-by: Tom Jungnickel <[email protected]>
Co-authored-by: Tom Jungnickel <[email protected]>
tjungni
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything is fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides an implementation of the model and process interface, which is also combined with an interface for differential and total cross-sections.
The model definition interface
In this PR, the model interface describes only static information, i.e. there is only one un-parameterized base type and a convenient interface function:
The process definition interface
In this PR, the process interface describes only static information about a scattering process. Here, a scattering process should be seen in a generic way, which forms a physical scattering process, if it is combined with a model definition above.
The process definition interface is defined as
Here, particle-like stands for subtypes of
AbstractParticleType
, so the static instances of particles.Additionally, in this PR, the following process related functions are implemented
Cross sections
Based in the interface funcitons for process and model definition, this PR also provides an interface for differential and total cross sections. This interface is definied my the following two functions:
where
initPS
andfinalPS
are vectors containing the four-momenta of the incoming and outgoing particles, respectively. The leading_
indicates, that the functions are not exported, and that no input-validation is applied. Additionally, there are versions of_differential_cross_section
and_total_cross_section
, which evaluate the respective quantity on a set of phase space points, i.e. a matrix of four-momenta, where the columns represent the momenta of the incoming or outgoing particles and the rows represent the different phase space points. Currently, only serial execution of the respective loops is implemented.Testing
The unit-tests for the interface have the following structure:
_FAIL
)Final remarks
The
README.md
is updated to include a small section on how-to build the documentation locally.