Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Julia version in CI #71

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

AntonReinhard
Copy link
Member

As the title says, update the Julia version used in the CI to 1.10, and use 1.10 and 1.11 additionally in automated unit tests.

@SimeonEhrig
Copy link
Member

Because Julia 1.11 is not released yet, there is no container with the tag.

https://hub.docker.com/_/julia

We could test rc but I'm not sure, what happen if Julia 1.11 is released. Maybe it will be removed, stuck to 1.11 or moved the 1.12 dev.

@AntonReinhard
Copy link
Member Author

We could test rc but I'm not sure, what happen if Julia 1.11 is released. Maybe it will be removed, stuck to 1.11 or moved the 1.12 dev.

That seems like the most reasonable option. I'd suspect that once 1.11 is released, the latest tag will be moved to 1.11 and the rc tag will be moved to 1.12. In any case we will have to update the CI again anyways when that happens, but at least it should not start to fail using rc then.

@AntonReinhard AntonReinhard marked this pull request as ready for review June 4, 2024 10:11
szabo137
szabo137 previously approved these changes Jun 4, 2024
Copy link
Member

@szabo137 szabo137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@SimeonEhrig
Copy link
Member

There are warnings in Julia 1.9 and Julia 1.10 which should be fixed a upcoming PR. Also for 1.10 there is a error for pre-compiling. But it looks like, this is not a big problem.

Copy link
Member

@szabo137 szabo137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM. Merge after pipeline succeeds.

@AntonReinhard AntonReinhard merged commit 8a7769d into QEDjl-project:dev Jun 19, 2024
4 checks passed
@AntonReinhard AntonReinhard deleted the update-julia-ci branch June 19, 2024 11:34
@szabo137 szabo137 added this to the Release-next milestone Jul 15, 2024
@szabo137 szabo137 added the 09 - Maintenance Related to maintenance, housekeeping, repo-config label Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
09 - Maintenance Related to maintenance, housekeeping, repo-config
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants