Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use dev branches in integTestGen.jl to create dependency graph #19

Merged

Conversation

SimeonEhrig
Copy link
Member

Before the commit, integTestGen.jl uses the packages from the registry to create the dependency graph. The causes a problem, if a QED sub package adds a dependency to another QED sub package and this change was not released. In this case, the generator takes the old version of the registry without the new dependency and does not generate a integration test for the package. Now it uses the dev branch by default or a custom repository and branch defined by the environment variable CI_INTG_PKG_URL_*.

@SimeonEhrig SimeonEhrig marked this pull request as ready for review October 12, 2023 10:36
@SimeonEhrig SimeonEhrig requested a review from szabo137 October 12, 2023 10:36
AntonReinhard
AntonReinhard previously approved these changes Oct 12, 2023
.ci/integTestGen/src/integTestGen.jl Outdated Show resolved Hide resolved
Before the commit, integTestGen.jl uses the packages from the registry to create the dependency graph. The causes a problem, if a QED sub package adds a dependency to another QED sub package and this change was not released. In this case, the generator takes the old version of the registry without the new dependency and does not generate a integration test for the package. Now it uses the dev branch by default or a custom repository and branch defined by the environment variable `CI_INTG_PKG_URL_*`.

Co-authored-by: Anton Reinhard <[email protected]>
Copy link
Member

@szabo137 szabo137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is straightforward and necessary. Many thanks for the fix, there are no concerns from my side, just a minor question. Ready for merging.

.ci/integTestGen/src/integTestGen.jl Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants