-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration tests #4
Conversation
092607c
to
7a6dfd5
Compare
Testing the PRTo test the PR, we need an unconventional setup. I tested the PR with the QED packages For testing purpose, I introduce a API break in QEDjl-project/QEDbase.jl#3. The CI of the commmit fails because |
@szabo137 Ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General feedback for the script:
mutable global variables should be used with caution, especially if this causes a dependence of a function on the state of the global scope. This may cause unpredictable behavior.
One solution, which is not perfect but better, is the passing of the global variable to the local scope of functions, i.e. passing them as an argument.
Maybe consider renaming the directory |
fd7418e
to
45e74c1
Compare
Could the first box in docs/src/integration_jobs_pipeline.svg be called "Stage: Test modified subpackages"? |
@tjungni I rewrote the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more small edits and some questions
a08134a
to
1a3547c
Compare
1a3547c
to
1c9d110
Compare
@tjungni Ready for merge? |
1c9d110
to
a2b0961
Compare
a2b0961
to
f95bdd0
Compare
- rename folder ci to .ci
…evelops` - overtake @tjungni feedback
f95bdd0
to
7958ae8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Every request was correctly addressed—no concerns from my side.
Ready for merge!
The PR adds the tool
integTestGen
.The
integTestGen.jl
creates jobs for the CI, which checks if the changes in PR does a API or behavior break which causes that other QED packages which use the package of PR does not work anymore.A detailed documentation is part of the PR. The doc also provides the documentation for the unit tests, introduced in PR #3.