Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add script to determine PR target branch in GitLab CI #43

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

SimeonEhrig
Copy link
Member

No description provided.

Copy link
Member

@AntonReinhard AntonReinhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we plan on having any automated tests for this functionality? I imagine it would be difficult because it would always rely on the internet and therefore would always be unstable (especially looking at the stability of github actions lately 👀 )

.ci/integTestGen/src/get_target_branch.jl Outdated Show resolved Hide resolved
@SimeonEhrig
Copy link
Member Author

Do we plan on having any automated tests for this functionality? I imagine it would be difficult because it would always rely on the internet and therefore would always be unstable (especially looking at the stability of github actions lately 👀 )

I have several json files, which I can add to test at least the json parser.

@AntonReinhard
Copy link
Member

I have several json files, which I can add to test at least the json parser.

Sounds good 👍

@SimeonEhrig
Copy link
Member Author

After a discussion, we decided to not add tests. There was only one pretty easy test. The rest depends on the internet. Therefore, there would be a lot of work, to modify the test infrastructure of the integrationTests package.

Instead, I uploaded some response from the GitHub API for a PR targeting a dev branch, a PR targeting a main branch and an non existing branch.

@AntonReinhard AntonReinhard merged commit dd3e79f into QEDjl-project:dev Aug 28, 2024
2 checks passed
@AntonReinhard AntonReinhard added this to the Release-0.1.0 milestone Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants