Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

does not use custom package URLs in SetupDevEnv.jl after PR #5

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

SimeonEhrig
Copy link
Member

After PR #3 I recognized, that lines starting with CI_UNIT_PKG_URL_ exist in the commit message of the merge request. This triggers accidentally custom URLs for packages in the SetupDevEnv.jl script. Because it does not make any sense to use custom URLs on the main and dev branch, this PR disable the feature for this branches.

Add also gitlab CI attribute interruptible: true that CI can be aborted if a new commit was pushed to the same branch.

@SimeonEhrig SimeonEhrig force-pushed the fixIntegrationTestDev branch from 0a17a84 to 09183af Compare July 11, 2023 07:38
- add gitlab CI attribute `interruptible: true` that CI can be aborted if a new commit was pushed to the same branch
@SimeonEhrig SimeonEhrig force-pushed the fixIntegrationTestDev branch 2 times, most recently from 0db5f12 to 45f8165 Compare July 11, 2023 08:34
@SimeonEhrig SimeonEhrig marked this pull request as ready for review July 11, 2023 08:34
@SimeonEhrig
Copy link
Member Author

@szabo137 Can you please review it. When you merge, please add the following line to the commit message of the merge commit. It is for testing purpose (you can also a comment above).

CI_UNIT_PKG_URL_QEDbase: https://github.com/SimeonEhrig/QEDbase.jl.git#barFunction

Copy link
Member

@szabo137 szabo137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No concerns from my side!

@szabo137 szabo137 merged commit 2d5deff into QEDjl-project:dev Jul 11, 2023
@AntonReinhard AntonReinhard added this to the Release-0.1.0 milestone Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants