fix integration test for merge in the main branch #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonReinhard
previously approved these changes
Sep 5, 2024
If we want to merge in the main branch, we do it because we want to publish the package. Therefore, we need to be sure that there is an existing version of the dependent QED packages that works with the new version of the package we want to release. The integration tests are tested against the development branch and the release version. - The dev branch version must pass, as this means that the latest version of the other QED packages is compatible with our release version. - The release version can exist. If they exist, it means that we do not need to release a new version of this package.
SimeonEhrig
force-pushed
the
fixIntegrationTestforMergeInMain
branch
from
bf77d43 to
da08934
Compare
|
The pipeline looks like expected: QEDjl-project/QEDcore.jl#57 |
|
Can you test it with a PR in QEDbase too? We should see the QEDprocesses Release test fail there. |
Yes I can. I was actual wondering, why it didn't failed. Now, I know I choose the wrong QED project 😅 |
AntonReinhard
approved these changes
Sep 5, 2024
|
The test run in QEDbase was successful and working as intended 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we want to merge in the main branch, we do it because we want to publish the package. Therefore, we need to be sure that there is an existing version of the dependent QED packages that works with the new version of the package we want to release. The integration tests are tested against the development branch and the release version.
I will open an test PR to test if the feature is correctly working. If it is working, I mark the PR for ready for review.