Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dev_dependencies regex #66

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Conversation

AntonReinhard
Copy link
Member

See https://regex101.com/r/oefHHb/1
The current version of the regex matches anything

@AntonReinhard
Copy link
Member Author

Well, it seems now we have a problem...
The integration tests try to use the now incorrect version on the dev branch, which this PR is supposed to fix
We might have to override the branch protection rule for this one.

@AntonReinhard AntonReinhard marked this pull request as draft September 11, 2024 14:39
@SimeonEhrig
Copy link
Member

Let's use this PR, to verify if all ci stuff is also working in other QED projects: QEDjl-project/QEDbase.jl#119

@AntonReinhard AntonReinhard force-pushed the fix-regex branch 2 times, most recently from 93d1216 to 49bc508 Compare September 12, 2024 08:41
@AntonReinhard AntonReinhard marked this pull request as ready for review September 12, 2024 08:42
@AntonReinhard
Copy link
Member Author

As mentioned previously, the docs build job will keep failing because it relies on the dev branch. The unit and integration tests in QEDjl-project/QEDbase.jl#119 worked though, so we will have to override merge this PR anyways, which should fix the problem. There's not really any way around this.

@SimeonEhrig SimeonEhrig merged commit bcdb98e into QEDjl-project:dev Sep 12, 2024
3 of 5 checks passed
@AntonReinhard AntonReinhard deleted the fix-regex branch September 12, 2024 09:30
@AntonReinhard AntonReinhard added this to the Release-0.1.0 milestone Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants