Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable norm check for hybridrep on spinor WFs #5287

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

camelto2
Copy link
Contributor

Please review the developer documentation
on the wiki of this project that contains help and requirements.

Proposed changes

Hybridrep spinor wave functions wasn't working because the orbital norm check was still being used in the hybridrep splines. This needs to be disabled since individual up/down components aren't normalized, only the total spinor is. This is now fixed, and enables hybridrep with spinors.

What type(s) of changes does this code introduce?

Delete the items that do not apply

  • Bugfix

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

mac

Checklist

Update the following with a yes where the items apply. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code.

  • Yes. This PR is up to date with current the current state of 'develop'
  • Yes. Code added or changed in the PR has been clang-formatted
  • No. This PR adds tests to cover any new code, or to catch a bug that is being fixed
  • No. Documentation has been added (if appropriate)

@ye-luo
Copy link
Contributor

ye-luo commented Jan 20, 2025

Test this please

@ye-luo ye-luo enabled auto-merge January 20, 2025 18:44
Copy link
Contributor

@prckent prckent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

=> We need a spinor variant of short-diamondC_1x1x1_hybridrep_pp, or some similar simple cell where the wavefunction is small enough to include in the repo. Clearly we are missing tests that hit this code bath and do basic sanity checks on the results, both statistical and deterministic. How would you prefer we test and catch these kinds of problems?

@ye-luo ye-luo merged commit e75a7ee into QMCPACK:develop Jan 20, 2025
36 of 37 checks passed
@camelto2 camelto2 deleted the fix_hybridrep_builder_spinor branch January 20, 2025 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants