Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix colors by passing stdio arguments explicitly #109

Merged
merged 1 commit into from
Apr 21, 2020

Conversation

blakeembrey
Copy link
Collaborator

Closes #108 based on local tests. Using the outpipe option will still end up without isTTY due to stdout of the command being the piped (from the node.js documentation, the default when null is 'pipe'). However, I believe this is mostly expected behavior.

@blakeembrey blakeembrey merged commit bd8619b into master Apr 21, 2020
@blakeembrey blakeembrey deleted the be/fix-stdio-tty-colors branch April 21, 2020 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary use of pipes disables terminal features
1 participant