Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pythonNet version 2.0.12 #6310

Merged
merged 3 commits into from
May 2, 2022

Conversation

Martin-Molinero
Copy link
Member

@Martin-Molinero Martin-Molinero commented Apr 28, 2022

Description

  • Bump pythonNet version 2.0.12
  • Updates after pythonNet rebase

Related Issue

See QuantConnect/pythonnet#64

Motivation and Context

Update

Requires Documentation Change

N/A

How Has This Been Tested?

Running tests, research.

Memory sanity test

Running CoarseFineFundamentalComboAlgorithm using self.__numberOfSymbols = 50;self.__numberOfSymbolsFine = 10
Master
image

PR
image

Performance sanity test:

HistoryRequestBenchmark PR
49.38 seconds at 37k data points per second. Processing total of 1,822,036 data points.
48.48 seconds at 38k data points per second. Processing total of 1,822,036 data points.
47.68 seconds at 38k data points per second. Processing total of 1,822,036 data points.
BasicTemplateBenchmark PR
51.53 seconds at 51k data points per second. Processing total of 2,639,319 data points.
51.72 seconds at 51k data points per second. Processing total of 2,639,319 data points.
50.72 seconds at 52k data points per second. Processing total of 2,639,319 data points.
BasicTemplateBenchmark MASTER
48.77 seconds at 54k data points per second. Processing total of 2,639,319 data points.
46.56 seconds at 57k data points per second. Processing total of 2,639,319 data points.
47.14 seconds at 56k data points per second. Processing total of 2,639,319 data points.
HistoryRequestBenchmark MASTER
46.75 seconds at 39k data points per second. Processing total of 1,822,036 data points.
47.13 seconds at 39k data points per second. Processing total of 1,822,036 data points.
48.57 seconds at 38k data points per second. Processing total of 1,822,036 data points.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

@Martin-Molinero Martin-Molinero force-pushed the refactor-rebase-pythonnet-from-trunk branch from 9de9fda to 70ec248 Compare April 28, 2022 22:05
@Martin-Molinero Martin-Molinero merged commit b9d3d99 into master May 2, 2022
@Martin-Molinero Martin-Molinero deleted the refactor-rebase-pythonnet-from-trunk branch May 2, 2022 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant