-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #24: Document symbolic single-qubit measurements sMX
, Register
and projectrand!
#330
base: master
Are you sure you want to change the base?
Conversation
…MX, Register and projectrand!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #330 +/- ##
==========================================
+ Coverage 82.44% 82.74% +0.30%
==========================================
Files 62 62
Lines 4186 4196 +10
==========================================
+ Hits 3451 3472 +21
+ Misses 735 724 -11 ☔ View full report in Codecov by Sentry. |
…d fix ci doc error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for starting this!
There are some stylistic points that are not bad, but do not match the current style of the documentation. Especially around repetitive examples.
This is a good reference on making documentaiton https://docs.divio.com/documentation-system/
For random seeds, StableRNGs should be used.
Random seed initialization should be hidden so it does not render in the html documentation (there is a # hide
meta comment that can be used)
To properly fix #24, we should have a clear separation between "algebra" and "circuit simulation" manuals. The first one exists. The second one has not been created.
Thanks for your wonderful comments! Indeed, a clear separation between "algebra" and "circuit simulation" is necessary along with all of your others valuable points to properly fix the issue. |
…cStringExtensions much more agressively
sMX
, Register
and projectrand!
sMX
, Register
and projectrand!
& use DocStringExtensions
much more agressively
Indeed, it is necessary to have clear distinction between the "algebra" and "circuit simulation" part of the documentation. Circuit Simulation Manual is added which introduce Classical Register (from Improved documentation of ECC example: http://qc.quantumsavory.org/stable/ecc_example_sim/ Pretty description for Destabilizer (in Covering missing
The initial attempt was bad, thanks a lot for your suggestions, they helped in improving the pr significantly! |
My sincere apologies for including the Issue 150 here as well. That's stupid of me. Hopefully, it would not happen again! |
sMX
, Register
and projectrand!
& use DocStringExtensions
much more agressivelysMX
, Register
and projectrand!
Thank you for reviewing the PR. The documentation guides really helped me and provided a new perspective of writing better documentation. Hopefully, the work is satisfactory and as per your needs and requirements. I realize how bad it was adding work from another issue here. Now things are back to normal. |
Thanks! I will probably not be able to review in the next 5 days, but if I do not respond by next weekend, do not hesitate to ping me. |
2e5e442
to
8d70457
Compare
@Krastanov, pinging as instructed. Apologies, as I have been imprecise when making review requests. Thanks for your time! |
Closes #24
Thanks a lot for your suggestions about fixing Issue 24 in the comments there. Indeed, there is a lot of documentation around this side of things that is currently not covered. This will help fix the gap and help users get accomodated with this functionality.
Thank you for reviewing the PR!