Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hecke's Small Groups (small_group(l, Id)) without any extra relations for single cyclic groups #406

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Fe-r-oz
Copy link
Contributor

@Fe-r-oz Fe-r-oz commented Oct 27, 2024

This PR introduces Hecke.small_group for 'abelian' 2BGA codes for single cyclic groups. Hecke.small groups are limited, they can only be used single cyclic groups.

  • The code is properly formatted and commented.
  • Substantial new functionality is documented within the docs.
  • All new functionality is tested.
  • All of the automated tests on github pass.
  • We recently started enforcing formatting checks. If formatting issues are reported in the new code you have written, please correct them. There will be plenty of old code that is flagged as we are slowly transitioning to enforced formatting. Please do not worry about or address older formatting issues -- keep your PR just focused on your planned contribution.

@Fe-r-oz Fe-r-oz changed the title Introducing Group Presentations via Hecke's Small Groups Introducing Group Presentations via Hecke's Small Groups for single cyclic groups Oct 27, 2024
Copy link

codecov bot commented Oct 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.95%. Comparing base (5fcf353) to head (9516be9).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #406      +/-   ##
==========================================
- Coverage   83.00%   82.95%   -0.05%     
==========================================
  Files          71       71              
  Lines        4565     4565              
==========================================
- Hits         3789     3787       -2     
- Misses        776      778       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fe-r-oz Fe-r-oz changed the title Introducing Group Presentations via Hecke's Small Groups for single cyclic groups using Hecke's Small Groups for single cyclic groups Oct 27, 2024
@Fe-r-oz Fe-r-oz changed the title using Hecke's Small Groups for single cyclic groups using Hecke's Small Groups without any extra relations for single cyclic groups Oct 27, 2024
@Fe-r-oz Fe-r-oz changed the title using Hecke's Small Groups without any extra relations for single cyclic groups using Hecke's Small Groups (small_group(l, Id)) without any extra relations for single cyclic groups Nov 27, 2024
@Fe-r-oz Fe-r-oz changed the title using Hecke's Small Groups (small_group(l, Id)) without any extra relations for single cyclic groups introducing Hecke's Small Groups (small_group(l, Id)) without any extra relations for single cyclic groups Nov 27, 2024
@Fe-r-oz Fe-r-oz changed the title introducing Hecke's Small Groups (small_group(l, Id)) without any extra relations for single cyclic groups Hecke's Small Groups (small_group(l, Id)) without any extra relations for single cyclic groups Nov 27, 2024
@Fe-r-oz Fe-r-oz marked this pull request as ready for review November 29, 2024 18:00
@Fe-r-oz
Copy link
Contributor Author

Fe-r-oz commented Dec 6, 2024

Please help review this PR, Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant