Some usability improvements for project_traceout!()
#35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
==========================================
+ Coverage 65.15% 65.51% +0.36%
==========================================
Files 23 23
Lines 927 928 +1
==========================================
+ Hits 604 608 +4
+ Misses 323 320 -3
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Krastanov
reviewed
Aug 29, 2023
| @@ -37,11 +37,13 @@ function observable(state::Union{<:Ket,<:Operator}, indices, operation) | |||
| expect(op, state) | |||
| end | |||
|
|
|||
| function project_traceout!(state::Union{Ket,Operator},stateindex,psis::Vector{<:Ket}) | |||
| function project_traceout!(state::Union{Ket,Operator},stateindex,psis::Union{Tuple,Vector{<:Ket}}) | |||
There was a problem hiding this comment.
let's use Base.AbstractVecOrTuple here (which is almost the same union), to keep things consistent
|
@Abhishek-1Bhatt , could you investigate what I broke here? |
ba2tro
commented
Sep 11, 2023
| @@ -37,11 +37,13 @@ function observable(state::Union{<:Ket,<:Operator}, indices, operation) | |||
| expect(op, state) | |||
| end | |||
|
|
|||
| function project_traceout!(state::Union{Ket,Operator},stateindex,psis::Vector{<:Ket}) | |||
| function project_traceout!(state::Union{Ket,Operator},stateindex,psis::Base.AbstractVecOrTuple{Ket}) | |||
There was a problem hiding this comment.
So, the problem is that the symbolic basis states like Z1, X2 etc aren't direct subtypes of Ket, but SpecialKet here.
Should I just replace it with
function project_traceout!(state::Union{Ket,Operator},stateindex,psis::Base.AbstractVecOrTuple{<:Union{Ket, QuantumSymbolics.SpecialKet}})
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows
project_traceout()to accept Tuples of possible basis states. Also added a more descriptive error message when the state to be measured is not normalized.