Symbolic Objects for Local and Remote entanglement generation processes #45

ba2tro · 2023-09-23T01:24:37Z

No description provided.

codecov · 2023-09-23T01:41:52Z

Codecov Report

Merging #45 (3201e1b) into master (d33a453) will decrease coverage by 0.71%.
The diff coverage is 56.73%.

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
- Coverage   64.00%   63.29%   -0.71%     
==========================================
  Files          23       27       +4     
  Lines         975     1079     +104     
==========================================
+ Hits          624      683      +59     
- Misses        351      396      +45

Files	Coverage Δ
src/QuantumSavory.jl	`59.68% <ø> (ø)`
src/StatesZoo/zalm_pair/ret_cxy.jl	`100.00% <100.00%> (ø)`
src/StatesZoo/StatesZoo.jl	`50.00% <50.00%> (ø)`
...ngle_dual_rail_midswap/single_dual_rail_midswap.jl	`91.30% <91.30%> (ø)`
src/StatesZoo/zalm_pair/zalm_pair.jl	`22.22% <22.22%> (ø)`

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Krastanov · 2023-09-23T19:54:28Z

May we reorganize things a bit. Could you make two folders inside of the newly created StatesZoo folder, one for each of the two new objects. And then keep the matlab code for each in the corresponding folder. Let's also have a name that describes a bit more the "why" not the "what".

Krastanov · 2023-09-23T19:57:39Z

something like

StatesZoo
- cascaded_source
-- precursor_code (that contains a readme explaining what was done to the code)
- entanglement_swap
-- precursor_code (again with explanation of what was done to it)

Keep in mind that these two things are very different types of processes and states, they should not be lumped together.

Also, keep the express statements local, do not put them in a completely different file (when you write them -- I thought they are implemented already, but I misread something).

Krastanov · 2023-09-24T02:11:03Z

We need to figure out how to name these objects.

For the cascaded source, Saikat and Dirk refer to it as "ZALM source" for Zero-added-noise Multiplexed. It comes from https://arxiv.org/abs/2206.03670 and https://arxiv.org/abs/2206.03670
So let's call the symbolic object ZALMpair and let's have it printed out as ρᶻᵃˡᵐ.

When you set up its doc string, please leave in [](@cite) references to these two papers. In terms of how to do the references, they need to be added as bibtex to the bibfile in the doc src folder. See for instance this pull request and the bibtex and docstrings in it https://github.com/QuantumSavory/QuantumSavory.jl/pull/37/files

The best way to get up-to-date bibtex references is from google scholar.

Krastanov · 2023-09-24T02:19:13Z

For the midswap folder, let's have two separate symbolic objects defined there. Maybe for names we can use DualRailMidSwapBell and SingleRailMidSwapBell. Not quite sure about the names, please feel free to suggest better ones. Not quite sure for their unicode/latex representation either. Maybe ρᵈʳᵐˢ and ρˢʳᵐˢ but again, please feel free suggesting something better.

Krastanov · 2023-09-24T02:47:37Z

In terms of how to do the symbolics, check out this file and how "SpecialKet" is done there https://github.com/QuantumSavory/QuantumSymbolics.jl/blob/main/src/QSymbolicsBase/predefined.jl

The issue is that we do not really have the same for density matrices. I think a good way to do this is to make abstract type AbstractTwoQubitState <: AbstractTwoQubitState end (that probably should be in QuantumSymbolics) and then make a struct ZALMPair <: AbstractTwoQubitState (in QuantumSavory).

ba2tro · 2023-09-25T03:10:53Z

The cascaded_source folder has two functions for generating density matrices, one in the spin-spin basis(called cascaded_source_spin) which outputs a 4x4 density matrix and another in fock basis(called cascaded_source_photonic) which outputs a 36x36 matrix, currently I have implemented the symbolic object ρᶻᵃˡᵐ being expressed as the one in spin-spin basis. Let me know what we should name the other one, it would be a small change.

Also, in the above comment the part

I think a good way to do this is to make abstract type AbstractTwoQubitState <: AbstractTwoQubitState end

was not clear, so for now I did abstract type AbstractTwoQubitState <: AbstractTwoQubitOp end , let me know if you feel we should do it differently.

Then, I was not sure if we need the const cascaded_source_basis as a symbolic object, so its currently left as such, let me know what you think would be the best way to represent it.

Krastanov · 2023-09-27T15:33:59Z

src/StatesZoo/zalm_pair/cascaced_source_swapped_with_memories/readme.md

+## Overview
+This folder contains the functions required to generate the spin-spin density matrix for a cascaded source swapped with emissive memories. The functions are written in MATLAB. The functions are:
+- cascaded_source_photonic.m : Generates the photonic density matrix for a cascaded source from the papers Refs. 1 and 2.
+- cascaded_source_spin.m : Generates the spin-spin density matrix for a cascaded source swapped with emissive spin memories from the papers Ref. 3.


@Abhishek-1Bhatt , can you confirm that we currently just implement cascaded_source_spin.m - the photinic and basis files might be used in the future, but are not currently used in any symbolic objects, right?

Yes, the function for photonic density matrix has been translated to Julia, but there is no symbolic object for it right now. Same with the basis, I have declared it as a const in the module file StatesZoo.jl but its not used anywhere.

Krastanov · 2023-09-27T15:59:51Z

src/StatesZoo/StatesZoo.jl

+using QuantumSymbolics: withmetadata, @withmetadata, Metadata
+import QuantumSymbolics: express_nolookup
+
+export cascaded_source_photonic, cascaded_source_spin, midswap_dual_rail, midswap_single_rail, ZALMpair


let's export only the symbolic objects (the structs), nothing else

Krastanov · 2023-09-27T16:00:42Z

src/StatesZoo/zalm_pair/cascaced_source_swapped_with_memories/readme.md

+
+## Reference
+1. [P. Dhara, S. J. Johnson, C. N. Gagatsos, P. G. Kwiat, S. Guha, Heralded Multiplexed High-Efficiency Cascaded Source of Dual-Rail Entangled Photon Pairs Using Spontaneous Parametric Down-Conversion. Phys. Rev. Appl. 17, 034071 (2022).](https://arxiv.org/abs/2107.14360)
+2. [K. C. Chen, et al., Zero-Added-Loss Entangled-Photon Multiplexing for Ground- and Space-Based Quantum Networks. Phys. Rev. Appl. 19, 054029 (2023).](https://arxiv.org/abs/2206.03670)


Reference 1 and 2 also matter. In ZALMPair we should say something along the lines "cascaded source (from 1 and 2) that is then stored in spin memories (from 3)". Could you update the references to include 1 and 2?

Krastanov · 2023-09-27T16:01:16Z

src/StatesZoo/zalm_pair/zalm_pair.jl

+
+"""
+Generate symbolic object for the spin-spin density matrix for a 
+cascaded source swapped with emissive spin memories from the paper [prajit2023entangling](@cite)


Here is where I am suggestion we also mention ref 1 and 2

Krastanov · 2023-09-27T16:01:45Z

src/StatesZoo/zalm_pair/zalm_pair.jl

+Generate symbolic object for the spin-spin density matrix for a 
+cascaded source swapped with emissive spin memories from the paper [prajit2023entangling](@cite)
+"""
+@withmetadata struct ZALMpair <: AbstractTwoQubitState


To distinguish from the photonic one, let's call it ZALMSpinPair

Krastanov · 2023-09-27T16:02:57Z

src/StatesZoo/zalm_pair/zalm_pair.jl

+cascaded source swapped with emissive spin memories from the paper [prajit2023entangling](@cite)
+"""
+@withmetadata struct ZALMpair <: AbstractTwoQubitState
+    Ns::Float64


Could you document what each of these parameters means? Prajit has that explained in his readmes -- basically just copy that, for all symbolic structs.

Krastanov · 2023-09-27T16:04:18Z

could you add a few tests, something along the lines of:

reg = Register(2)
initialize!(reg[1:2], symbolicstate)
observable(reg[1:2], some_observable)

just to make sure that the API is not broken

ba2tro added 5 commits September 20, 2023 22:15

copy matlab files

0cd6fd5

just raw arrangement into a module

c366e3f

code cleanup

68401b2

cleanup

2ebd925

update readme.md

42606a4

Krastanov changed the title ~~Translated Matlab code~~ Symbolic Objects for Local and Remote entanglement generation processes Sep 23, 2023

Rearrange the code and add symbolics

41fd369

ba2tro and others added 4 commits September 26, 2023 13:05

Merge branch 'QuantumSavory:master' into stateszoo

665eb0d

Renamed files and added refs

eab2aa2

Some documenting

33fea8d

corrections

219d129

Krastanov reviewed Sep 27, 2023

View reviewed changes

ba2tro added 4 commits September 27, 2023 13:00

add more references

5719bb5

rename to ZALMSpinPair

4c51137

detailed documentation for symbolic objects

0c39f90

added tests

3201e1b

Krastanov merged commit b784e1b into QuantumSavory:master Sep 28, 2023
1 of 9 checks passed

ba2tro deleted the stateszoo branch September 29, 2023 15:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Symbolic Objects for Local and Remote entanglement generation processes #45

Symbolic Objects for Local and Remote entanglement generation processes #45

ba2tro commented Sep 23, 2023

codecov bot commented Sep 23, 2023 •

edited

Loading

Krastanov commented Sep 23, 2023

Krastanov commented Sep 23, 2023 •

edited

Loading

Krastanov commented Sep 24, 2023

Krastanov commented Sep 24, 2023

Krastanov commented Sep 24, 2023

ba2tro commented Sep 25, 2023 •

edited

Loading

Krastanov Sep 27, 2023

ba2tro Sep 27, 2023

Krastanov Sep 27, 2023

Krastanov Sep 27, 2023

Krastanov Sep 27, 2023

Krastanov Sep 27, 2023

Krastanov Sep 27, 2023

Krastanov commented Sep 27, 2023

Symbolic Objects for Local and Remote entanglement generation processes #45

Symbolic Objects for Local and Remote entanglement generation processes #45

Conversation

ba2tro commented Sep 23, 2023

codecov bot commented Sep 23, 2023 • edited Loading

Codecov Report

Krastanov commented Sep 23, 2023

Krastanov commented Sep 23, 2023 • edited Loading

Krastanov commented Sep 24, 2023

Krastanov commented Sep 24, 2023

Krastanov commented Sep 24, 2023

ba2tro commented Sep 25, 2023 • edited Loading

Krastanov Sep 27, 2023

Choose a reason for hiding this comment

ba2tro Sep 27, 2023

Choose a reason for hiding this comment

Krastanov Sep 27, 2023

Choose a reason for hiding this comment

Krastanov Sep 27, 2023

Choose a reason for hiding this comment

Krastanov Sep 27, 2023

Choose a reason for hiding this comment

Krastanov Sep 27, 2023

Choose a reason for hiding this comment

Krastanov Sep 27, 2023

Choose a reason for hiding this comment

Krastanov commented Sep 27, 2023

codecov bot commented Sep 23, 2023 •

edited

Loading

Krastanov commented Sep 23, 2023 •

edited

Loading

ba2tro commented Sep 25, 2023 •

edited

Loading