Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added QuantumChannel #53
Added QuantumChannel #53
Changes from 8 commits
1367b58
9ae1e44
6507a7a
acb2982
dd5da70
55c6256
85e282b
37cc012
96b6bf2
eeb78fb
3e7de53
ee598ab
a1077e9
da158a5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does
channel_reg
has itstime
value correctly set after theswap!
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean the
accesstimes
attribute? No, it only swaps thestaterefs
andstateindices
of theRegRef
s, should we edit the current swap! to do so?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If
swap!
properly updates thetime
value, then this should beqc.queue.delay+now(qc.queue.store.env)
Check warning on line 80 in src/quantumchannel.jl
Codecov / codecov/patch
src/quantumchannel.jl#L78-L80