Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed doctests #60

Merged
merged 10 commits into from
Nov 17, 2023
Merged

Fixed doctests #60

merged 10 commits into from
Nov 17, 2023

Conversation

ba2tro
Copy link
Member

@ba2tro ba2tro commented Nov 17, 2023

No description provided.

@Krastanov
Copy link
Member

Is buildkite not running because we do not have a queue entry in it anymore?

@Krastanov
Copy link
Member

nope that does not seem to be the reason...

@Krastanov
Copy link
Member

oh, I see! buildkite is not running on pull requests from third party repositories as a security precaution

image

... I enabled it... let's see how soon I will regret this

@Krastanov
Copy link
Member

ok, now I think all tests are running correctly.

There are two outstanding issues:

  1. this test fails because of a change in the hash of some arbitrary object https://buildkite.com/quantumsavory/ci-buildkite/builds/56#018bdbbc-cbce-4e65-a5d9-5302adaf69c5/369-2581
    I thought I had fixed that with the use of the filter above it, but I guess I must have done something incorrectly with the filter.
  2. A lot of the changes you had made like Qubit -> QuantumSavory.Qubit now seem like have to be reverted. I have had this happen often to me, it has something to do with what modules are imported when the tests run, and I frequently get it wrong (something to do with testing from the REPL vs testing from runtests.jl due to difference in exactly what is imported). It is a pretty annoying one :(

If point 1 takes you more than 15 minutes to fix, just change the docstring so that it just does not print that information. No need to waste a ton of time on something so menial.

@codecov Codecov
Copy link

codecov bot commented Nov 17, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e33370e) 72.38% compared to head (7d1fb2f) 81.70%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
+ Coverage   72.38%   81.70%   +9.32%     
==========================================
  Files          28       27       -1     
  Lines        1108      973     -135     
==========================================
- Hits          802      795       -7     
+ Misses        306      178     -128

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Krastanov
Copy link
Member

woohoo! Thank you! These green checkmarks make me feel so much better. I will merge shortly.

Krastanov
Krastanov reviewed Nov 17, 2023
View reviewed changes
Copy link
Member

@Krastanov Krastanov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edit: comment placed by accident

@ba2tro
Copy link
Member Author

ba2tro commented Nov 17, 2023

Yes! it is really validating, haha

@Krastanov Krastanov merged commit e9896fd into QuantumSavory:master Nov 17, 2023
7 of 9 checks passed
@Krastanov Krastanov mentioned this pull request Nov 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Krastanov Krastanov Krastanov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ba2tro @Krastanov