entanglement tracker and swapper added to ProtocolZoo, with significant improvements to the query and messaging systems #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r in which they are inserted)
…t instead of having explicit connections with channels
…update remote who-is-entangled-with-whom information) -- still needs classical message routing
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #81 +/- ##
==========================================
+ Coverage 72.87% 74.98% +2.10%
==========================================
Files 29 37 +8
Lines 1132 1399 +267
==========================================
+ Hits 825 1049 +224
- Misses 307 350 +43 ☔ View full report in Codecov by Sentry. |
ba2tro
commented
Dec 20, 2023
|
Could you squish the last 3 commits so all the changes relative to the previous PR are easy to read? |
Krastanov
reviewed
Dec 20, 2023
Krastanov
reviewed
Dec 20, 2023
Krastanov
reviewed
Dec 20, 2023
I should have said "squash". And I misread the number of commits. Could you squash all the new commits into a single commit with a description of what was done? If we need some additional steps after this is done we will squash them too (or just use |
ba2tro
force-pushed
the
ab/firstgenrepeaterv2
branch
from
52cc4ba to
d8268d9
Compare
ba2tro
commented
Dec 21, 2023
ba2tro
force-pushed
the
ab/firstgenrepeaterv2
branch
3 times, most recently
from
c9f691c to
1f58d09
Compare
ba2tro
commented
Dec 23, 2023
ba2tro
force-pushed
the
ab/firstgenrepeaterv2
branch
from
259b382 to
92a7af0
Compare
Krastanov
reviewed
Dec 29, 2023
use a counter to keep track of race conditions in messagebuffer and lower bounds for stdlibs compat
ba2tro
force-pushed
the
ab/firstgenrepeaterv2
branch
from
92a7af0 to
788576c
Compare
Krastanov
changed the title
This was referenced Dec 30, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.